linux-kernel - Re: [resend][PATCH] fs: use kernel's hex_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110104161439.f30ab73c.akpm@linux-foundation.org>
Date:	Tue, 4 Jan 2011 16:14:39 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org, Mimi Zohar <zohar@...ibm.com>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	David Howells <dhowells@...hat.com>,
	James Morris <jmorris@...ei.org>
Subject: Re: [resend][PATCH] fs: use kernel's hex_to_bin() method

On Wed, 5 Jan 2011 01:58:56 +0200
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Wed, Jan 5, 2011 at 1:21 AM, Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> > After which we can change your patch thusly:
> >
> > --- a/fs/binfmt_misc.c~fs-binfmt_miscc-use-kernels-hex_to_bin-method-fix
> > +++ a/fs/binfmt_misc.c
> > @@ -244,9 +244,7 @@ static int unquote(char *from)
> >
> >        while ((c = *s++) != '\0') {
> >                if (c == '\\' && *s == 'x') {
> > -                       s++;
> > -                       *p = hex_to_bin(*s++) << 4;
> > -                       *p++ |= hex_to_bin(*s++);
> > +                       s = (char *)hex2bin(p, s + 1, 1);
> We need to update both p and s.
> 
> In case of '\xAA\xBB' you have result -> '0xBB'.
> Am I wrong?
> 
> >                        continue;
> >                }
> >                *p++ = c;

I'm more into shopping and nagging at people than this programming
thingy.  Sigh.

--- a/fs/binfmt_misc.c~fs-binfmt_miscc-use-kernels-hex_to_bin-method-fix-fix
+++ a/fs/binfmt_misc.c
@@ -243,11 +243,10 @@ static int unquote(char *from)
 	char c = 0, *s = from, *p = from;
 
 	while ((c = *s++) != '\0') {
-		if (c == '\\' && *s == 'x') {
-			s = (char *)hex2bin(p, s + 1, 1);
-			continue;
-		}
-		*p++ = c;
+		if (c == '\\' && *s == 'x')
+			s = (char *)hex2bin(p++, s + 1, 1);
+		else
+			*p++ = c;
 	}
 	return p - from;
 }
_


How does one test this thing?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/