linux-kernel - Re: [34-longterm 251/260] USB: atmel_usba_udc: force vbus_pin at -EINVAL when gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Jan 2011 16:29:21 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
Cc:	stable@...nel.org, linux-kernel@...r.kernel.org,
	stable-review@...nel.org, Nicolas Ferre <nicolas.ferre@...el.com>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [34-longterm 251/260] USB: atmel_usba_udc: force vbus_pin at
 -EINVAL when gpio_request failled

[Re: [34-longterm 251/260] USB: atmel_usba_udc: force vbus_pin at -EINVAL when gpio_request failled] On 05/01/2011 (Wed 19:59) Jean-Christophe PLAGNIOL-VILLARD wrote:

> On 02:19 Sun 02 Jan     , Paul Gortmaker wrote:
> > From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
> > 
> > commit 969affff54702785330de553b790372e261e93f9 upstream.
> > 
> > to ensure gpio_is_valid return false
> > 
> > Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> > ---
> >  drivers/usb/gadget/atmel_usba_udc.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
> > index 75a256f..8fd88e1 100644
> > --- a/drivers/usb/gadget/atmel_usba_udc.c
> > +++ b/drivers/usb/gadget/atmel_usba_udc.c
> > @@ -2015,6 +2015,9 @@ static int __init usba_udc_probe(struct platform_device *pdev)
> >  			} else {
> >  				disable_irq(gpio_to_irq(udc->vbus_pin));
> >  			}
> > +		} else {
> > +			/* gpio_request fail so use -EINVAL for gpio_is_valid */
> > +			ubc->vbus_pin = -EINVAL;
> there is a typo here
> please change to 
> 			udc->vbus_pin = -EINVAL;

Thanks -- I see I had the upstream typo fix (b488095186318) already
queued up in next_round; but it looks like it needs to be dragged back
into this round.

I'll go do that now.

Paul.

> 
> Best Regards,
> J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/