linux-kernel - Re: [PATCH] leds/h1940: Use gpiolib for latch access / fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Jan 2011 09:08:13 +0200
From:	Vasily Khoruzhick <anarsoul@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Peter Huewe <peterhuewe@....de>, Ben Dooks <ben-linux@...ff.org>,
	Vincent Sanders <support@...tec.co.uk>,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH] leds/h1940: Use gpiolib for latch access / fix build failure

On Wednesday 05 January 2011 01:37:25 Andrew Morton wrote:
> On Fri, 10 Dec 2010 00:16:57 +0200
> 
> Vasily Khoruzhick <anarsoul@...il.com> wrote:
> > On Friday 10 December 2010 00:04:52 Peter Huewe wrote:
> > > This patch fixes a build failure by converting leds-h1940.c to use
> > > gpiolib for latch access introduced by 14477095abc6
> > > (ARM: h1940: Use gpiolib for latch access)
> > > 
> > > Unfortunately this driver was not converted back then.
> > 
> > I sent similar patch (however, my patch does gpio_request/gpio_free)
> > ~month ago.
> > 
> > Here's link:
> > http://www.spinics.net/lists/arm-kernel/msg103429.html
> 
> So which patch to use?
> 
> I queued Peter's patch because it's simpler.  I queued it for
> 2.6.38-rc1, taged for backporting into 2.6.37.x, so we have a bit of
> time to think about it.

It's simplier, but it does not request gpio before use. It will work, but will 
print nasty warning.

Regards,
Vasily
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/