linux-kernel - Re: [Stable-review] [06/49] drm/kms: remove spaces from connector names (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 Jan 2011 00:04:44 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Greg KH <gregkh@...e.de>, Alex Deucher <alexdeucher@...il.com>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	Sergej Pupykin <ml@...gej.pp.ru>,
	Dave Airlie <airlied@...hat.com>, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org, stable-review@...nel.org,
	alan@...rguk.ukuu.org.uk
Subject: Re: [Stable-review] [06/49] drm/kms: remove spaces from connector
 names (v2)

On Wed, 2011-01-05 at 15:56 -0800, Greg KH wrote:
> On Wed, Jan 05, 2011 at 11:49:05PM +0000, Ben Hutchings wrote:
> > On Wed, 2011-01-05 at 15:00 -0800, Greg KH wrote:
> > > 2.6.32-longterm review patch.  If anyone has any objections, please let us know.
> > > 
> > > ------------------
> > > 
> > > From: Alex Deucher <alexdeucher@...il.com>
> > > 
> > > commit e76116ca9671e2e5239054a40303b94feab585ad upstream.
> > > 
> > > Grub doesn't parse spaces in parameters correctly, so
> > > this makes it impossible to force video= parameters
> > > for kms on the grub kernel command line.
> > > 
> > > v2: shorten the names to make them easier to type.
> > [...]
> > > --- a/drivers/gpu/drm/drm_crtc.c
> > > +++ b/drivers/gpu/drm/drm_crtc.c
> > > @@ -144,10 +144,10 @@ static struct drm_conn_prop_enum_list dr
> > >  	{ DRM_MODE_CONNECTOR_SVIDEO, "SVIDEO", 0 },
> > >  	{ DRM_MODE_CONNECTOR_LVDS, "LVDS", 0 },
> > >  	{ DRM_MODE_CONNECTOR_Component, "Component", 0 },
> > > -	{ DRM_MODE_CONNECTOR_9PinDIN, "9-pin DIN", 0 },
> > > -	{ DRM_MODE_CONNECTOR_DisplayPort, "DisplayPort", 0 },
> > > -	{ DRM_MODE_CONNECTOR_HDMIA, "HDMI Type A", 0 },
> > > -	{ DRM_MODE_CONNECTOR_HDMIB, "HDMI Type B", 0 },
> > > +	{ DRM_MODE_CONNECTOR_9PinDIN, "DIN", 0 },
> > > +	{ DRM_MODE_CONNECTOR_DisplayPort, "DP", 0 },
> > [...]
> > 
> > Why change 'DisplayPort', which doesn't have a space in it?  This might
> > break a previously working kernel command line.
> 
> That's what happened in Linus's tree, I just mirror it :)

Yeah, sorry, that was really directed at Alex.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)