[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110106124525.GA1717@bicker>
Date: Thu, 6 Jan 2011 15:45:25 +0300
From: Dan Carpenter <error27@...il.com>
To: Sven Neumann <s.neumann@...mfeld.com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mtd@...ts.infradead.org, Daniel Mack <daniel@...aq.de>,
leiwen@...vell.com, haojian.zhuang@...vell.com,
David.Woodhouse@...el.com, eric.y.miao@...il.com,
Artem.Bityutskiy@...ia.com
Subject: [patch] mtd: pxa3xx_nand: NULL dereference in pxa3xx_nand_probe
Hi Sven,
Could you test this patch? I don't have an arm so I can't compile this.
This was introduced in 18c81b1828f8 "mtd: pxa3xx_nand: remove the flash
info in driver structure"
Signed-off-by: Dan Carpenter <error27@...il.com>
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index 17f8518..ea2c288 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -885,6 +885,7 @@ static int pxa3xx_nand_detect_config(struct pxa3xx_nand_info *info)
/* set info fields needed to __readid */
info->read_id_bytes = (info->page_size == 2048) ? 4 : 2;
info->reg_ndcr = ndcr;
+ info->cmdset = &default_cmdset;
if (__readid(info, &id))
return -ENODEV;
@@ -915,7 +916,6 @@ static int pxa3xx_nand_detect_config(struct pxa3xx_nand_info *info)
info->ndtr0cs0 = nand_readl(info, NDTR0CS0);
info->ndtr1cs0 = nand_readl(info, NDTR1CS0);
- info->cmdset = &default_cmdset;
return 0;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists