linux-kernel - Re: [PATCH] RS485 on Cris: use global value of TIOCSRS485

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D25F4A8.7050702@evidence.eu.com>
Date:	Thu, 06 Jan 2011 17:58:16 +0100
From:	Claudio Scordino <claudio@...dence.eu.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	starvik@...s.com, Jesper Nilsson <Jesper.Nilsson@...s.com>,
	linux-cris-kernel <linux-cris-kernel@...s.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RS485 on Cris: use global value of TIOCSRS485

Il 06/01/2011 14:34, Alan Cox ha scritto:
>> With this patch, TIOCSRS485 gets the same value across all
>> architectures, making maintenance and portability of user-level code
>> easier.
>
> I don't see why this is worth doing - no application code should ever
> hardcode the value.

I'm afraid this is true only in a theoretical world. But I hope I'm
wrong.

Actually, I can't see any reason to keep different values of TIOCSRS485
in the kernel code when we can have a single value across all
architectures.

But I trust your judgment: if you say it's not worth doing, let's
avoid it.

Many thanks,

	Claudio
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/