linux-kernel - Re: [GIT PATCH] TTY/serial merge for .38

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTiman4=gGxMccUu41tvt19imiSvnhTe3wm9p-s2r@mail.gmail.com>
Date:	Fri, 7 Jan 2011 00:54:05 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	Greg KH <gregkh@...e.de>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PATCH] TTY/serial merge for .38

On Thu, Jan 6, 2011 at 23:24, Greg KH <gregkh@...e.de> wrote:
> On Thu, Jan 06, 2011 at 10:00:17PM +0000, Alan Cox wrote:
>> > There was some arguing about the tty console detection patches, but as
>> > the existing ioctl does not work properly, Kay's patch was accepted to
>> > resolve this issue and allow systemd to correctly detect consoles.  I
>> > know Alan doesn't like this, but I feel it's the best way to solve the
>> > issue (combined with the fact that there is no proposed other solution.)
>>
>> I'm a bit confused about this one Greg - all the distributions used the
>> ioctl you refer to below for this purpose and have for years
>>
>> > This series also includes the long-out-of-tree ioctl that SUSE and
>> > Debian have been dragging around in their kernels for the past 10+
>> > years.  Thanks to Werner for finally submitting it in a mergable form.
>>
>> Which I believe means we don't need the sysfs patch as well - Kay ?
>
> I didn't think that the ioctl was sufficient for what systemd required,
> it was only needed for "old-style" initrd programs like what used to be
> used in SUSE and other distros, but are now being phased out.

We want all involved ttys below /dev/console not only the primary one.
Also we like to get notified about re-configs, hence the poll()
support. Both is not covered at the moment, or by the old, now to be
merged, ioctl.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/