linux-kernel - Re: + hugetlb-handle-nodemask_alloc-failure-correctly.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110107082536.GA1891@tiehlicka.suse.cz>
Date:	Fri, 7 Jan 2011 09:25:36 +0100
From:	Michal Hocko <mhocko@...e.cz>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, caiqian@...hat.com,
	nacc@...ibm.com, linux-kernel@...r.kernel.org
Subject: Re: + hugetlb-handle-nodemask_alloc-failure-correctly.patch added
 to -mm tree

On Thu 06-01-11 16:42:06, David Rientjes wrote:
> On Thu, 6 Jan 2011, akpm@...ux-foundation.org wrote:
[...]
> This patch is wrong, both functions may handle a NULL nodes_allowed, which 
> is why the __GFP_NORETRY is explicitly part of the gfp mask.
> 
> In both functions, init_nodemask_of_mempolicy() will immediately return 
> false if the mask is NULL.  If so, it is set to node_states[N_HIGH_MEMORY] 
> in the caller and we're careful to avoid calling the NODMASK_FREE() in 
> that case.  They are carefully coded in this way so they operate over all 
> nodes with memory rather than failing with -ENOMEM.

OK, I see. Thanks for the review.

-- 
Michal Hocko
L3 team 
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/