linux-kernel - Re: [PATCH] x86: use PCI method for enabling AMD extended config space before MSR method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <4D27243D020000780002B00C@vpn.id2.novell.com>
Date:	Fri, 07 Jan 2011 13:33:33 +0000
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	"Robert Richter" <robert.richter@....com>,
	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Andreas Herrmann3" <Andreas.Herrmann3@....com>,
	"Joerg Roedel" <Joerg.Roedel@....com>,
	"Jeremy Fitzhardinge" <jeremy@...p.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hpa@...or.com" <hpa@...or.com>
Subject: Re: [PATCH] x86: use PCI method for enabling AMD extended
	 config space before MSR method

>>> On 07.01.11 at 13:58, Ingo Molnar <mingo@...e.hu> wrote:

> * Robert Richter <robert.richter@....com> wrote:
> 
>> On 06.01.11 18:20:04, Robert Richter wrote:
>> > On 06.01.11 11:57:35, Jan Beulich wrote:
>> > > While both methods should work equivalently well for the native case,
>> > > the Xen Dom0 case can't reliably work with the MSR one, since there's
>> > > no guarantee that the virtual CPUs it has available fully cover all
>> > > necessary physical ones.
>> > > 
>> > > As per the suggestion of Robert Richter the patch only adds the PCI
>> > > method, but leaves the MSR one as a fallback to cover new systems the
>> > > PCI IDs of which may not have got added to the code base yet.
>> > > 
>> > > Signed-off-by: Jan Beulich <jbeulich@...ell.com>
>> > > Cc: Robert Richter <robert.richter@....com>
>> > > Cc: Joerg Roedel <Joerg.Roedel@....com>
>> > > Cc: Andreas Herrmann <Andreas.Herrmann3@....com>
>> > > Cc: Jeremy Fitzhardinge <jeremy@...p.org>
>> > > 
>> > > ---
>> > >  arch/x86/include/asm/amd_nb.h |    7 ++++++
>> > >  arch/x86/kernel/amd_nb.c      |    7 ++++++
>> > >  arch/x86/kernel/aperture_64.c |   44 +++++++++++++++---------------------------
>> > >  arch/x86/pci/amd_bus.c        |   30 ++++++++++++++++++++++++++++
>> > >  4 files changed, 60 insertions(+), 28 deletions(-)
>> 
>> Btw, the patch should be relative to tip/x86/amd-nb as there would be
>> conflicts otherwise due to other changes.
> 
> that's upstream meanwhile, so a patch against -git or -tip would suffice.

Yes, will do as soon as I can get to it.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/