linux-kernel - Re: [PATCH 3/6] x86, NMI: Add priorities to handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110107144318.GU2317@redhat.com>
Date:	Fri, 7 Jan 2011 09:43:18 -0500
From:	Don Zickus <dzickus@...hat.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	x86@...nel.org, Robert Richter <robert.richter@....com>,
	ying.huang@...el.com, gorcunov@...il.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/6] x86, NMI: Add priorities to handlers

On Fri, Jan 07, 2011 at 02:09:51PM +0100, Peter Zijlstra wrote:
> >  static struct event_constraint unconstrained;
> > diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
> > index cd21b65..983fb54 100644
> > --- a/arch/x86/kernel/kgdb.c
> > +++ b/arch/x86/kernel/kgdb.c
> > @@ -606,7 +606,7 @@ static struct notifier_block kgdb_notifier = {
> >  	/*
> >  	 * Lowest-prio notifier priority, we want to be notified last:
> >  	 */
> > -	.priority	= -INT_MAX,
> > +	.priority	= NMI_LOCAL_LOW_PRIOR,
> >  };
> >  
> >  /**
> 
> 
> I had to add the below to make things build here.
> 
> ---
> Index: linux-2.6/arch/x86/kernel/kgdb.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/kgdb.c
> +++ linux-2.6/arch/x86/kernel/kgdb.c
> @@ -48,6 +48,7 @@
>  #include <asm/apicdef.h>
>  #include <asm/system.h>
>  #include <asm/apic.h>
> +#include <asm/nmi.h>
>  
>  struct dbg_reg_def_t dbg_reg_def[DBG_MAX_REG_NUM] =
>  {
> 

Doh.  I missed a spot.  Thanks for the catch.  I'll add that and repost.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/