linux-kernel - Re: [PATCH] input: joystick: Adding Austria Microsystem AS5011 joystick driver (third version)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Jan 2011 11:50:00 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Fabien Marteau <fabien.marteau@...adeus.com>
Cc:	Trilok Soni <tsoni@...eaurora.org>,
	Scott Moreau <oreaus@...il.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: joystick:   Adding Austria Microsystem AS5011
 joystick driver (third version)

On Fri, Jan 07, 2011 at 08:42:37PM +0100, Fabien Marteau wrote:
> On 04/01/2011 12:01, Trilok Soni wrote:
> > Hi Fabien,
> > 
> > On 1/4/2011 3:17 PM, Fabien Marteau wrote:
> >> +
> >> +static irqreturn_t as5011_int_interrupt(int irq, void *dev_id)
> >> +{
> >> +	struct as5011_platform_data *plat_dat = dev_id;
> >> +
> >> +	mutex_lock(&plat_dat->update_lock);
> >> +	as5011_update_axes(plat_dat);
> >> +	mutex_unlock(&plat_dat->update_lock);
> > 
> > Please explain this lock. Sorry if I have missed out your explanation in the earlier threads.
> 
> If a second interruption occurs the first update must be finished before update again.

The ISR handler will not be called simultaneously on several CPUs. What
else can it race with?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/