linux-kernel - Re: [PATCH] dma: shdma: don't register the global die notifier multiple times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110107015918.GI22477@linux-sh.org>
Date:	Fri, 7 Jan 2011 10:59:18 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	linux-sh@...r.kernel.org, Magnus Damm <damm@...nsource.se>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma: shdma: don't register the global die notifier multiple times

On Thu, Jan 06, 2011 at 06:04:50PM +0100, Guennadi Liakhovetski wrote:
> A recent patch has added a die notifier to the shdma driver, however, 
> it registers a static die-notifier object in the probe routine, i.e., 
> for each device instance. This is wrong and leads to a system lockup. 
> This patch moves the die notifier registration to module init and 
> exit routines respectively.
> 
> Reported-by: Magnus Damm <damm@...nsource.se>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de>
> ---
> 
> This fixes the lock up on sh7372. Patch against current sh-2.6/master.
> 
Whoops, I suppose I should have tested on a platform with more than one
DMAC :-)

I'll piggyback this on top of the rmobile-latest branch, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/