linux-kernel - Re: [PATCH v2] Documentation: Add evdev type and code definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 07 Jan 2011 17:15:17 -0500
From:	Chase Douglas <chase.douglas@...onical.com>
To:	Nikolai Kondrashov <spbnick@...il.com>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Henrik Rydberg <rydberg@...omail.se>,
	Chris Bagwell <chris@...bagwell.com>,
	Peter Hutterer <peter.hutterer@...-t.net>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Documentation: Add evdev type and code definitions

On 01/07/2011 05:06 PM, Nikolai Kondrashov wrote:
> On 01/08/2011 12:28 AM, Chase Douglas wrote:
>> +* BTN_TOOL_<name>:
>> +  - These codes are used in conjunction with input trackpads, tablets, and
>> +    touchscreens. These devices may be used with fingers, pens, or other tools.
>> +    When an event occurs and a tool is used, the corresponding BTN_TOOL_<name>
>> +    code should be set to a value of 1. When the tool is no longer interacting
>> +    with the input device, the BTN_TOOL_<name>  code should be reset to 0. All
>> +    trackpads, tablets, and touchscreens should use at least one BTN_TOOL_<name>
>> +    code when events are generated.
> 
> There are some tablets (namely UC-Logic ones), which do not indicate tool
> proximity. Yet they may have both a pen and a mouse. They just send reports
> with separate report IDs. Currently it is solved by using
> HID_QUIRK_MULTI_INPUT and not sending any BTN_TOOL_* events.
> 
> Should the documentation reflect the fact that some tablets do not send any
> BTN_TOOL_* events, or should the drivers be updated to synthesise them?

I think it should be stated more obviously that all evdev codes are
optional except for specific cases, such as BTN_TOUCH for any type of
touch device. My understanding is that BTN_TOOL_<name> is optional.

Perhaps I should do something like the following for all the evdev codes:

* <evdev code>:
  - Usage: Required|Optional|Required when ... etc.
  - <description>

> Note that in the latter case there will never be a BTN_TOOL_* with
> zero value when the tool leaves the digitizing area, but only when the tools
> are switched (if ever).

Hmm.. That seems incorrect to me. Why wouldn't it follow the behavior
outlined above?

-- Chase
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/