lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 8 Jan 2011 15:07:40 +0100 From: Sam Ravnborg <sam@...nborg.org> To: Guan Xuetao <guanxuetao@...c.pku.edu.cn> Cc: 'Arnd Bergmann' <arnd@...db.de>, linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCHv1 01/12] unicore32 core architecture: build infrastructure > > > > Overall, I can see that there has been a lot of good progress in the code since > > the original versions that I looked at, very nice! > > > > > diff --git a/arch/unicore32/.gitignore b/arch/unicore32/.gitignore > > > new file mode 100644 > > > index 0000000..f0fc866 > > > --- /dev/null > > > +++ b/arch/unicore32/.gitignore > > > @@ -0,0 +1,70 @@ > > > +# > > > +# Generated include files > > > +# > > > +include/asm/atomic.h > > > +include/asm/auxvec.h > > > +include/asm/bitsperlong.h > > > +include/asm/bug.h > > > +include/asm/bugs.h > > > +include/asm/cputime.h > > > +include/asm/current.h > > > +include/asm/device.h > > > +include/asm/emergency-restart.h > > > +include/asm/errno.h > > > +include/asm/fb.h > > > +include/asm/fcntl.h > > > +include/asm/hardirq.h > > > ... > > > > Maybe it would be better to put these files into a separate directory, like > > arch/unicore32/include/generated/asm, to make it easier to separate them > > from the other files and avoid listing them all in .gitignore besides the > > other places. > > That's great, and I make the following changes: ... I have made a second attempt to provice generic support for asm-generic headers as you likely have seen. IMO you shall keep your own solution until we get generic support. In other words - you shall avoid being dependent on this. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists