linux-kernel - Re: [PATCH 1/2] watchdog: Add support for sp5100 chipset TCO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110109093319.GI3801@infomag.iguana.be>
Date:	Sun, 9 Jan 2011 10:33:19 +0100
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Mike Waychison <mikew@...gle.com>
Cc:	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
	Priyanka Gupta <priyankag@...gle.com>
Subject: Re: [PATCH 1/2] watchdog: Add support for sp5100 chipset TCO

Hi Mike,

> The cleanups above seem fine to me.  What did you mean by "Change
> reboot_notifier by a platform shutdown" though?  I see that you
> removed the reboot_notifier, which is fine for our purposes.  Was this
> a suggestion to have this stuff get called from platform code if
> needed?  Am I missing something?

The platform_driver struct has a shutdown operation which does the same
as the reboot_notifier. Since the code is smaller and since the binary is
smaller we prefer to use the shutdown operation. So I removed the
reboot_notifier and added the shutdown operation.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/