| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201101101724.46023.christoph.paasch@uclouvain.be> Date: Mon, 10 Jan 2011 17:24:45 +0100 From: Christoph Paasch <christoph.paasch@...ouvain.be> To: Randy Dunlap <rdunlap@...otime.net> Cc: Alexey Dobriyan <adobriyan@...il.com>, Ben Hutchings <bhutchings@...arflare.com>, davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Cleanup include/net/tcp.h include-files and coding-style On Monday, January 10, 2011 wrote Randy Dunlap: > Documentation/SubmitChecklist, #1: > > 1: If you use a facility then #include the file that defines/declares > that facility. Don't depend on other header files pulling in ones > that you use. Ok, great. That was the answer I was looking for. So, there is a clear rule that defines the #include-policy. Now, should the missing #include's be added, or not? Alexey Dobriyan is against it, as he says in one of his previous mails. And, I'm nearly sure that the rule is not respected in plenty of other files of the Linux Kernel. Cheers, Christoph -- Christoph Paasch PhD Student IP Networking Lab --- http://inl.info.ucl.ac.be MultiPath TCP in the Linux Kernel --- http://inl.info.ucl.ac.be/mptcp Université Catholique de Louvain www.rollerbulls.be -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists