linux-kernel - Re: [PATCH 1/2] kbuild: asm-generic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110110162639.GB13763@merkur.ravnborg.org>
Date:	Mon, 10 Jan 2011 17:26:39 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Guan Xuetao <guanxuetao@...c.pku.edu.cn>
Cc:	'lkml' <linux-kernel@...r.kernel.org>,
	'linux-kbuild' <linux-kbuild@...r.kernel.org>,
	'linux arch' <linux-arch@...r.kernel.org>,
	'Arnd Bergmann' <arnd@...db.de>,
	'Michal Marek' <mmarek@...e.cz>
Subject: Re: [PATCH 1/2] kbuild: asm-generic support

Hi Guan (I will try to spell you name correct fom now on!)

> > +	During the prepare phase of the build a wrapper include
> > +	file is generated in the directory:
> > +
> > +		arch/$(ARCH)/include/generated/asm
> IMHO, the directory could be include/generated/asm

We have moved all the arch specific files away from include/*
which is why I invented arch/$(ARCH)/include/generated.

I was actually considering:

   arch/$(ARCH)/generated.

But using include/generated just seems wrong.

> > 
> >  # Work out what needs to be removed
> > @@ -47,8 +54,12 @@ quiet_cmd_install = INSTALL $(printdir) ($(words $(all-files))\
> >        cmd_install = \
> >          $(PERL) $< $(srctree)/$(obj) $(install) $(SRCARCH) $(header-y); \
> >          $(PERL) $< $(objtree)/$(obj) $(install) $(SRCARCH) $(objhdr-y); \
> > +        for F in $(wrapper-files); do                                   \
> > +                echo "\#include <asm-generic/$$F>" > $(install)/$$F;    \
> > +        done;                                                           \
> >          touch $@
> > 
> > +
> Empty line.
> 

Will fix.

As noticed in another mail the patchset has the same issue with rebuilding.
This will likewise be included in next version.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/