linux-kernel - Re: [PATCH] rcu: call __rcu_read_unlock() in exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110110021559.GG2383@linux.vnet.ibm.com>
Date:	Sun, 9 Jan 2011 18:15:59 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] rcu: call __rcu_read_unlock() in exit_rcu()

On Tue, Jan 04, 2011 at 04:32:25PM +0800, Lai Jiangshan wrote:
> 
> rcu_read_unlock() is a wrapper of many things:
> 	the core __rcu_read_unlock(), debugs...etc.
> 
> It is better that we only calls the core __rcu_read_unlock() here.

Hello, Lai!

Last time I checked, a task exiting in an RCU read-side critical section
got an error before it got to this point.  That said, the "__" does a
good job of indicating that this is not a normal end of an RCU read-side
critical section.

I have queued this at least for the moment, and also created a TINY_RCU
counterpart.

							Thanx, Paul

> signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
> ---
> diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
> index a363871..94035a0 100644
> --- a/kernel/rcutree_plugin.h
> +++ b/kernel/rcutree_plugin.h
> @@ -802,7 +802,7 @@ void exit_rcu(void)
>  	if (t->rcu_read_lock_nesting == 0)
>  		return;
>  	t->rcu_read_lock_nesting = 1;
> -	rcu_read_unlock();
> +	__rcu_read_unlock();
>  }
> 
>  #else /* #ifdef CONFIG_TREE_PREEMPT_RCU */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/