linux-kernel - error: implicit declaration of function 'msleep' (was: Re: [media] radio-aimslab.c: Fix gcc 4.5+ bug)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 10 Jan 2011 20:48:49 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	stable@...nel.org
Subject: error: implicit declaration of function 'msleep' (was: Re: [media]
 radio-aimslab.c: Fix gcc 4.5+ bug)

On Fri, Jan 7, 2011 at 04:02, Linux Kernel Mailing List
<linux-kernel@...r.kernel.org> wrote:
> Gitweb:     http://git.kernel.org/linus/e3c92215198cb6aa00ad38db2780faa6b72e0a3f
> Commit:     e3c92215198cb6aa00ad38db2780faa6b72e0a3f
> Parent:     a7862aa90ffd1113bc2898ae6be2e4861b1f76cc
> Author:     Mauro Carvalho Chehab <mchehab@...hat.com>
> AuthorDate: Thu Jan 6 08:16:04 2011 -0200
> Committer:  Mauro Carvalho Chehab <mchehab@...hat.com>
> CommitDate: Thu Jan 6 08:26:02 2011 -0200
>
>    [media] radio-aimslab.c: Fix gcc 4.5+ bug
>
>    gcc 4.5+ doesn't properly evaluate some inlined expressions.
>    A previous patch were proposed by Andrew Morton using noinline.
>    However, the entire inlined function is bogus, so let's just
>    remove it and be happy.
>
>    Reported-by: Andrew Morton <akpm@...ux-foundation.org>
>    Cc: stable@...nel.org
>    Signed-off-by: Mauro Carvalho Chehab <mchehab@...hat.com>
> ---
>  drivers/media/radio/radio-aimslab.c |   23 ++++++-----------------
>  1 files changed, 6 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/media/radio/radio-aimslab.c b/drivers/media/radio/radio-aimslab.c
> index 05e832f..6cc5d13 100644
> --- a/drivers/media/radio/radio-aimslab.c
> +++ b/drivers/media/radio/radio-aimslab.c
> @@ -31,7 +31,6 @@
>  #include <linux/module.h>      /* Modules                      */
>  #include <linux/init.h>                /* Initdata                     */
>  #include <linux/ioport.h>      /* request_region               */
> -#include <linux/delay.h>       /* udelay                       */

Woops...

>  static void rt_decvol(struct rtrack *rt)
>  {
>        outb(0x58, rt->io);             /* volume down + sigstr + on    */
> -       sleep_delay(100000);
> +       msleep(100);

... still needed due to msleep(), cfr.
http://kisskb.ellerman.id.au/kisskb/buildresult/3776074/:

| drivers/media/radio/radio-aimslab.c:76: error: implicit declaration
of function 'msleep'

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/