linux-kernel - Re: [PATCH] USB SD Host Controller: Including usb.h once is enough

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110110213735.GA6509@void.printf.net>
Date:	Mon, 10 Jan 2011 21:37:36 +0000
From:	Chris Ball <cjb@...top.org>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Wolfram Sang <w.sang@...gutronix.de>, linux-mmc@...r.kernel.org,
	trivial@...nel.org, linux-kernel@...r.kernel.org,
	Axel Lin <axel.lin@...il.com>,
	David Vrabel <david.vrabel@....com>
Subject: Re: [PATCH] USB SD Host Controller: Including usb.h once is enough

Hi Jesper,

On Mon, Jan 10, 2011 at 10:19:11PM +0100, Jesper Juhl wrote:
> > On Mon, Jan 10, 2011 at 09:56:08PM +0100, Jesper Juhl wrote:
> > > 
> > > Including usb.h once is enough in drivers/mmc/host/ushc.c
> > > This removes the duplicate.
> > > 
> > > 
> > > Signed-off-by: Jesper Juhl <jj@...osbits.net>

Thanks, queued for .38.

> No reason.
> Didn't think of it as "newlines in the commit-msg", just as newlines 
> providing a nice seperation between patch description and the patch 
> itself. It never occurred to me that anyone would actually copy those 
> blank lines into an actual commit message.

I don't copy anything into the commit message -- I like to run git-am
on the patch mail in my mailbox directly.  In this case, git-am seems
to have removed the extra newlines itself, which was nice of it, but in
general please send mail such that from the start of the body of the
mail up to the "---" separator will become the commit message.  Thanks!

-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/