linux-kernel - Re: [PATCH] i2c-i801: Add missing <linux/slab.h> include.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D2AAB3C.1080009@kernel.org>
Date:	Mon, 10 Jan 2011 08:46:20 +0200
From:	Pekka Enberg <penberg@...nel.org>
To:	Michael Cree <mcree@...on.net.nz>
CC:	Randy Dunlap <randy.dunlap@...cle.com>,
	linux-kernel@...r.kernel.org, linux-alpha@...r.kernel.org,
	Matt Turner <mattst88@...il.com>, Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Bob Tracy <rct@...rkin.frus.com>,
	David Woodhouse <David.Woodhouse@...el.com>
Subject: Re: [PATCH] i2c-i801: Add missing <linux/slab.h> include.

On 1/10/11 6:44 AM, Michael Cree wrote:
> Causes compile error on Alpha, but not on x86 because its version
> of<asm/pci.h>  includes<linux/slab.h>.  In any case, it's a bug
> in the driver.
>
> Signed-off-by: Michael Cree<mcree@...on.net.nz>

Acked-by: Pekka Enberg <penberg@...nel.org>

> ---
>
> Since no one else has submitted the patch here it goes.  Shall I send it
> directly to Linus (since I plan to send some Alpha specific patches very
> soon) or will the subsytem maintainers pick it up?

I'd let Andrew sort it out. (hi Andrew! ;-)

>   drivers/i2c/busses/i2c-i801.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 02835ce..7979aef 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -72,6 +72,7 @@
>   #include<linux/acpi.h>
>   #include<linux/io.h>
>   #include<linux/dmi.h>
> +#include<linux/slab.h>
>
>   /* I801 SMBus address offsets */
>   #define SMBHSTSTS(p)	(0 + (p)->smba)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/