linux-kernel - Re: [RFC V10 3/7] drivers:media:radio: wl128x: FM Driver Common sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110111112434.GE2385@legolas.emea.dhcp.ti.com>
Date:	Tue, 11 Jan 2011 13:24:34 +0200
From:	Felipe Balbi <balbi@...com>
To:	manjunatha_halli@...com
Cc:	mchehab@...radead.org, hverkuil@...all.nl,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [RFC V10 3/7] drivers:media:radio: wl128x: FM Driver Common
 sources

Hi,

On Tue, Jan 11, 2011 at 06:31:23AM -0500, manjunatha_halli@...com wrote:
> From: Manjunatha Halli <manjunatha_halli@...com>
> 
> These are the sources for the common interfaces required by the
> FM V4L2 driver for TI WL127x and WL128x chips.
> 
> These implement the FM channel-8 protocol communication with the
> chip. This makes use of the Shared Transport as its transport.
> 
> Signed-off-by: Manjunatha Halli <manjunatha_halli@...com>
> Reviewed-by: Hans Verkuil <hverkuil@...all.nl>

looks like this is implementing a "proprietary" (by that I mean: for
this driver only) IRQ API. Why aren't you using GENIRQ with threaded
IRQs support ?

Core IRQ Subsystem would handle a lot of stuff for you.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/