linux-kernel - Re: perf: commit 55b4462 causes perf record to hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Jan 2011 09:35:02 -0200
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	David Ahern <daahern@...co.com>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>, tzanussi@...il.com,
	Paul Mackerras <paulus@...ba.org>, imunsie@....ibm.com,
	linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: perf: commit 55b4462 causes perf record to hang

Em Tue, Jan 11, 2011 at 09:28:25AM +0100, Thomas Gleixner escreveu:
> On Mon, 10 Jan 2011, Arnaldo Carvalho de Melo wrote:
> > Can you try with this patch, not reverting tglx's patch?
> > 
> > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> > index 6fb4694..313dac2 100644
> > --- a/tools/perf/util/session.c
> > +++ b/tools/perf/util/session.c
> > @@ -1007,7 +1007,7 @@ more:
> >  	if (size == 0)
> >  		size = 8;
> >  
> > -	if (head + event->header.size >= mmap_size) {
> > +	if (head + event->header.size > mmap_size) {
> >  		if (mmaps[map_idx]) {
> >  			munmap(mmaps[map_idx], mmap_size);
> >  			mmaps[map_idx] = NULL;
> > 
> 
> /me feels stupid

I feel like that sometimes too, probably more often than you :-P

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/