linux-kernel - Re: [RFC V10 3/7] drivers:media:radio: wl128x: FM Driver Common sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Jan 2011 18:12:40 +0530
From:	Raja Mani <rajambsc@...il.com>
To:	balbi@...com
Cc:	manjunatha_halli@...com, mchehab@...radead.org, hverkuil@...all.nl,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [RFC V10 3/7] drivers:media:radio: wl128x: FM Driver Common sources

balbi,

  Agree , interrupt pkts could have handled in thread context . But in
the current way , FM driver never create any additional task in the
system
  to handle FM interrupt. In fact, there is no task being created in
this driver to handle FM RDS data, AF,etc.

  This method is suitable for light weight system where we want to
reduce number of thread in the system.

 On Tue, Jan 11, 2011 at 4:54 PM, Felipe Balbi <balbi@...com> wrote:
> Hi,
>
> On Tue, Jan 11, 2011 at 06:31:23AM -0500, manjunatha_halli@...com wrote:
>> From: Manjunatha Halli <manjunatha_halli@...com>
>>
>> These are the sources for the common interfaces required by the
>> FM V4L2 driver for TI WL127x and WL128x chips.
>>
>> These implement the FM channel-8 protocol communication with the
>> chip. This makes use of the Shared Transport as its transport.
>>
>> Signed-off-by: Manjunatha Halli <manjunatha_halli@...com>
>> Reviewed-by: Hans Verkuil <hverkuil@...all.nl>
>
> looks like this is implementing a "proprietary" (by that I mean: for
> this driver only) IRQ API. Why aren't you using GENIRQ with threaded
> IRQs support ?
>
> Core IRQ Subsystem would handle a lot of stuff for you.
>
> --
> balbi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Regards,
Raja.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/