linux-kernel - Re: [PATCH v3] mm: add replace_page_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Jan 2011 23:25:28 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	akpm@...ux-foundation.org, kamezawa.hiroyu@...fujitsu.com,
	nishimura@....nes.nec.co.jp, linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mm: add replace_page_cache_page() function

On Tue, Jan 11, 2011 at 03:07:54PM +0100, Miklos Szeredi wrote:
> (resent with fixed CC list, sorry for the duplicate)
> 
> Thanks for the review.
> 
> Here's an updated patch.  Modifications since the last post:
> 
>  - don't pass gfp_mask (since it's only able to deal with GFP_KERNEL
>    anyway)
> 

I am not sure it's a good idea.
Now if we need just GFP_KERNEL, we can't make sure it in future.
Sometime we might need GFP_ATOMIC and friendd functions
(ex, add_to_page_cache_lru,add_to_page_cache_locked) already have gfp_mask.
It's a exported function so it's hard to modify it in future.

I want to keep it.
Instead of removing it, we can change mem_cgroup_prepare_migration as
getting gfp_mask.

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/