linux-kernel - Re: [PATCH] rt2x00: Don't leak mem in error path of rt2x00lib_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTinEbfAsMiFaoC_XBTDOD7pOoUeTBXjXfiiOKof7@mail.gmail.com>
Date:	Tue, 11 Jan 2011 19:33:13 +0200
From:	Pekka Enberg <penberg@...nel.org>
To:	Ivo Van Doorn <ivdoorn@...il.com>
Cc:	Jesper Juhl <jj@...osbits.net>, linux-wireless@...r.kernel.org,
	users@...x00.serialmonkey.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Gertjan van Wingerde <gwingerde@...il.com>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH] rt2x00: Don't leak mem in error path of rt2x00lib_request_firmware()

On Tue, Jan 11, 2011 at 7:30 PM, Ivo Van Doorn <ivdoorn@...il.com> wrote:
> Hi,
>
>> We need to release_firmware() in order not to leak memory.
>>
>> Signed-off-by: Jesper Juhl <jj@...osbits.net>
>
> I can assume that release_firmware() checks if 'fw' is null?

Yes, it does.

> If so:
>
> Acked-by: Ivo van Doorn <IvDoorn@...il.com>

Acked-by: Pekka Enberg <penberg@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/