linux-kernel - Re: [PATCH v2] hid-multitouch: changes from the review process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Jan 2011 18:38:24 +0100
From:	Benjamin Tissoires <benjamin.tissoires@...c.fr>
To:	Henrik Rydberg <rydberg@...math.org>
Cc:	Stephane Chatty <chatty@...c.fr>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hid-multitouch: changes from the review process

On Tue, Jan 11, 2011 at 6:35 PM, Henrik Rydberg <rydberg@...math.org> wrote:
> On Tue, Jan 11, 2011 at 04:45:54PM +0100, Benjamin Tissoires wrote:
>> * amended Kconfig (PixCir and Hanvon are the same panel but with
>>   different name)
>> * insert field name in mt_class and retrieving it in mt_probe
>> * add 2 quirks: MT_QUIRK_VALID_IS_INRANGE, MT_QUIRK_VALID_IS_CONFIDENCE,
>>   in order to find the field "valid"
>> * inlined slot_is_contactid and slot_is_contact_number
>> * cosmetics changes (tabs and comments)
>> * do not send unnecessary properties once the touch is up
>>
>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...c.fr>
>
> There are some syntactic suboptimalities in the resulting file that
> perhaps could be fixed, but content-wise, I have nothing further. So,
> given that it actually works,
>
> Acked-by: Henrik Rydberg <rydberg@...omail.se>
>
> Thank you very much for your work, Benjamin.

Thanks for the review Henrik,

Cheers,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/