linux-kernel - Re: [PATCH 3/6] perf tools: Emit clearer message for sys_perf_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D2CA417.7030407@cisco.com>
Date:	Tue, 11 Jan 2011 11:40:23 -0700
From:	David Ahern <daahern@...co.com>
To:	Arnaldo Carvalho de Melo <acme@...radead.org>
CC:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	Tom Zanussi <tzanussi@...il.com>
Subject: Re: [PATCH 3/6] perf tools: Emit clearer message for sys_perf_event_open
 ENOENT return



On 01/10/11 17:28, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@...hat.com>
> 
> Improve sys_perf_event_open ENOENT return handling in top and record, just
> like 5a3446b does for stat.
> 
> Cc: David Ahern <daahern@...co.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Mike Galbraith <efault@....de>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Stephane Eranian <eranian@...gle.com>
> Cc: Tom Zanussi <tzanussi@...il.com>
> LKML-Reference: <new-submission>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  tools/perf/builtin-record.c |    3 +++
>  tools/perf/builtin-top.c    |    2 ++
>  2 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 7bc0490..7069bd3 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -331,6 +331,9 @@ try_again:
>  			else if (err ==  ENODEV && cpu_list) {
>  				die("No such device - did you specify"
>  					" an out-of-range profile CPU?\n");
> +			} else if (err == ENOENT) {
> +				die("%s event is not supported. ",
> +				     event_name(evsel));

I think this interferes with the fallback from hardware profiling to
software profiling. .e.g., in a VM with no PMU.

David


>  			} else if (err == EINVAL && sample_id_all_avail) {
>  				/*
>  				 * Old kernel, no attr->sample_id_type_all field
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 1e67ab9..6ce4042 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -1247,6 +1247,8 @@ try_again:
>  				die("Permission error - are you root?\n"
>  					"\t Consider tweaking"
>  					" /proc/sys/kernel/perf_event_paranoid.\n");
> +			if (err == ENOENT)
> +				die("%s event is not supported. ", event_name(evsel));
>  			/*
>  			 * If it's cycles then fall back to hrtimer
>  			 * based cpu-clock-tick sw counter, which
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/