linux-kernel - Re: [GIT PATCH] USB merge for .38

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Jan 2011 14:00:19 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Greg KH <gregkh@...e.de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Paul Walmsley <paul@...an.com>, Anand Gadiyar <gadiyar@...com>,
	Felipe Balbi <balbi@...com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [GIT PATCH] USB merge for .38

* Greg KH <gregkh@...e.de> [110107 14:05]:
> On Fri, Jan 07, 2011 at 01:22:40PM -0800, Linus Torvalds wrote:
> > On Thu, Jan 6, 2011 at 3:50 PM, Greg KH <gregkh@...e.de> wrote:
> > >
> > > Nothing radical here at all, lots of musb changes, which touched a bunch
> > > of arch-specific code, and some new drivers, mostly gadget ones.
> > 
> > There were also a number of conflicts with the ARM updates (omap clock
> > data in particular - added aliases, changed names, you name it).
> > 
> > I spent some time trying to fix it up properly, and maybe I even
> > succeeded, but you guys should really look the result over.
> 
> The drivers/usb/* changes look good to me.  I know Tony was looking at
> the omap merge issues, and if there was one, I think he had the needed
> fixup.
> 
> thanks for doing the merge.

The merge was good thanks. The clock changes in the omap tree caused
a minor issue, I have the following patch queued up to fix it. Will
post a pull request soonish along with few other patches.

Regards,

Tony

From: Santosh Shilimkar <santosh.shilimkar@...com>
Date: Sun, 9 Jan 2011 22:16:13 +0000
Subject: [PATCH] omap3: clocks: Fix build error 'CK_3430ES2' undeclared here

At latest mainline commit 0c21e3aaf6a,  omap2plus build is broken. This
patch is trivial fix for the missed usb clock node for CK_3430ES2PLUS
flag update.

 CHK     include/generated/compile.h
  CC      arch/arm/mach-omap2/clock3xxx_data.o
arch/arm/mach-omap2/clock3xxx_data.c:3289: error: 'CK_3430ES2' undeclared
here (not in a function)
make[1]: *** [arch/arm/mach-omap2/clock3xxx_data.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@...com>
Acked-by: Anand Gadiyar <gadiyar@...com>
Acked-by: Paul Walmsley <paul@...an.com>
[tony@...mide.com: updated mask to include CK_36XX]
Signed-off-by: Tony Lindgren <tony@...mide.com>

--- a/arch/arm/mach-omap2/clock3xxx_data.c
+++ b/arch/arm/mach-omap2/clock3xxx_data.c
@@ -3286,7 +3286,7 @@ static struct omap_clk omap3xxx_clks[] = {
 	CLK(NULL,	"cpefuse_fck",	&cpefuse_fck,	CK_3430ES2PLUS | CK_AM35XX | CK_36XX),
 	CLK(NULL,	"ts_fck",	&ts_fck,	CK_3430ES2PLUS | CK_AM35XX | CK_36XX),
 	CLK(NULL,	"usbtll_fck",	&usbtll_fck,	CK_3430ES2PLUS | CK_AM35XX | CK_36XX),
-	CLK("ehci-omap.0",	"usbtll_fck",	&usbtll_fck,	CK_3430ES2 | CK_AM35XX),
+	CLK("ehci-omap.0",	"usbtll_fck",	&usbtll_fck,	CK_3430ES2PLUS | CK_AM35XX | CK_36XX),
 	CLK("omap-mcbsp.1",	"prcm_fck",	&core_96m_fck,	CK_3XXX),
 	CLK("omap-mcbsp.5",	"prcm_fck",	&core_96m_fck,	CK_3XXX),
 	CLK(NULL,	"core_96m_fck",	&core_96m_fck,	CK_3XXX),
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/