linux-kernel - Re: [PATCH 3/4] memstick: add support for legacy memorysticks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <757175.38063.qm@web37603.mail.mud.yahoo.com>
Date:	Mon, 10 Jan 2011 18:48:43 -0800 (PST)
From:	Alex Dubov <oakad@...oo.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Maxim Levitsky <maximlevitsky@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH 3/4] memstick: add support for legacy memorysticks

> +
> +    case 2: /* send INT request */
> +        if
> (msb_read_int_reg(msb, -1))
> +           
> break;
> +        msb->state++;
> +
> +    case 3: /* get result of the INT

I still think it would look nicer if you could name your state with explicit
names and use "next_state()" or something to move on, instead of just
incrementing it.
Otherwise, I have no principal objections.



      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/