linux-kernel - Re: [PATCH] proc: proc_inode pid/fd and sysctl/sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTikcOeow+O4QUNWLwGprgQR0QgopaUgH-0pCDoQg@mail.gmail.com>
Date:	Wed, 12 Jan 2011 12:29:54 +0200
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Lucian Adrian Grijincu <lucian.grijincu@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Vlad Dogaru <ddvlad@...edu.org>,
	Octavian Purdila <opurdila@...acom.com>
Subject: Re: [PATCH] proc: proc_inode pid/fd and sysctl/sysctl_entry are never
 used at the same time

On Wed, Jan 12, 2011 at 12:14 PM, Lucian Adrian Grijincu
<lucian.grijincu@...il.com> wrote:
> Or at least I could not find a place where both are
> used at the same time.

See proc_evict_inode().

>  struct proc_inode {
> -       struct pid *pid;
> -       int fd;
> -       union proc_op op;
> +       union {
> +               struct {
> +                       int fd;
> +                       struct pid *pid;
> +               };
> +               struct {
> +                       struct ctl_table_header *sysctl;
> +                       struct ctl_table *sysctl_entry;
> +               };
> +       };
>         struct proc_dir_entry *pde;
> -       struct ctl_table_header *sysctl;
> -       struct ctl_table *sysctl_entry;
> +       union proc_op op;
>         struct inode vfs_inode;
>  };
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/