linux-kernel - Re: [PATCH] sound: constify functions in ac97

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hei8i838t.wl%tiwai@suse.de>
Date:	Wed, 12 Jan 2011 18:02:10 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Hanno Böck <hanno@...eck.de>,
	alsa-devel@...a-project.org, perex@...ex.cz,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: constify functions in ac97

At Wed, 12 Jan 2011 14:44:07 +0200,
Alexey Dobriyan wrote:
> 
> On Wed, Jan 12, 2011 at 1:03 PM, Hanno Böck <hanno@...eck.de> wrote:
> >  struct snd_ac97_build_ops {
> > -       int (*build_3d) (struct snd_ac97 *ac97);
> > -       int (*build_specific) (struct snd_ac97 *ac97);
> > -       int (*build_spdif) (struct snd_ac97 *ac97);
> > -       int (*build_post_spdif) (struct snd_ac97 *ac97);
> > +       int (* const build_3d) (struct snd_ac97 *ac97);
> > +       int (* const build_specific) (struct snd_ac97 *ac97);
> > +       int (* const build_spdif) (struct snd_ac97 *ac97);
> > +       int (* const build_post_spdif) (struct snd_ac97 *ac97);
> >  #ifdef CONFIG_PM
> > -       void (*suspend) (struct snd_ac97 *ac97);
> > -       void (*resume) (struct snd_ac97 *ac97);
> > +       void (* const suspend) (struct snd_ac97 *ac97);
> > +       void (* const resume) (struct snd_ac97 *ac97);
> >  #endif
> > -       void (*update_jacks) (struct snd_ac97 *ac97);   /* for jack-sharing */
> > +       /* for jack-sharing */
> > +       void (* const update_jacks) (struct snd_ac97 *ac97);
> 
> Can we please not do this.
> 
> You made whole ops structure RO, this is enough.

Yes.  Hanno, could you fix and resubmit?


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/