linux-kernel - CONFIG_NLS=m resulting in undefined reference to utf16s_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Jan 2011 12:10:17 -0800
From:	<Narendra_K@...l.com>
To:	<linux-kernel@...r.kernel.org>, <linux-next@...r.kernel.org>,
	<jbarnes@...tuousgeek.org>, <sfr@...b.auug.org.au>
CC:	<Matt_Domsch@...l.com>, <Charles_Rose@...l.com>,
	<Surya_Prabhakar@...l.com>
Subject: CONFIG_NLS=m resulting in undefined reference to utf16s_to_utf8s
 causing build failure

Hello,

As described in the post http://marc.info/?l=linux-next&m=129478755528194&w=2
setting CONFIG_NLS=m (generated by 'make allmodconfig) is causing a build
failure on linux-next as following while compiling the patch 
http://marc.info/?l=linux-pci&m=129313294112736&w=1 ([PATCH V2] Export
ACPI _DSM provided firmware instance number and string to sysfs)

drivers/built-in.o: In function `dsm_label_utf16s_to_utf8s':
/usr/src/Linux-Next/linux-next/drivers/pci/pci-label.c:195: undefined reference to `utf16s_to_utf8s'
make: *** [.tmp_vmlinux1] Error 1

The drivers/pci/pci-label.c is compiled as part of vmlinux as defined by
the makefile drivers/pci/Makefile. 

#
# ACPI Related PCI FW Functions
# ACPI _DSM provided firmware instance and string name
#
obj-$(CONFIG_ACPI)    += pci-acpi.o pci-label.o

# SMBIOS provided firmware instance and labels
obj-$(CONFIG_DMI)    += pci-label.o

This could be prevented by one of the following methods -

* forcing CONFIG_NLS=y if CONFIG_PCI=y 
* move `utf16s_to_utf8s' out of nls_base.c to a new file to be always
built into vmlinux

Please correct me if i missed something here and let me know what would be the right
way to fix this build failure.

With regards,
Narendra K





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/