linux-kernel - Re: [PATCH] Rename struct task variables from p to tsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimFGNxJzNMAJg-mWN-VOxonQ+odE9WBEEEsaw5O@mail.gmail.com>
Date:	Thu, 13 Jan 2011 08:14:12 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	Eric B Munson <emunson@...bm.net>
Cc:	akpm@...ux-foundation.org, linux-mm@...ck.org, mel@....ul.ie,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Rename struct task variables from p to tsk

On Thu, Jan 13, 2011 at 12:19 AM, Eric B Munson <emunson@...bm.net> wrote:
> p is not a meaningful identifier, this patch replaces all instances
> in page_alloc.c of p when used as a struct task with the more useful
> tsk.
>

Yesterday, Andrew raise an eyebrow about that.
His simple lookup found below.

--

On Tue, 11 Jan 2011 13:03:22 -0800 (PST)
Hugh Dickins <hughd@...gle.com> wrote:
> On Tue, 11 Jan 2011, Andrew Morton wrote:
< snip >
> > Oh, and since when did we use `p' to identify task_structs?
>
> Tsk, tsk: we've been using `p' for task_structs for years and years!

Only bad people do that.  "p".  Really?

z:/usr/src/linux-2.6.37> grep -r " \*p;" . | wc -l
2329
z:/usr/src/linux-2.6.37> grep -r "task_struct \*p" . | wc -l
824

bah.

-- 

How about cleaning up everything in this chance?




-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/