linux-kernel - Re: [PATCH] ACPI, APEI, Generic Hardware Error Source POLL/IRQ/NMI notification type support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <alpine.LFD.2.02.1101112341350.11311@x980>
Date:	Tue, 11 Jan 2011 23:55:24 -0500 (EST)
From:	Len Brown <lenb@...nel.org>
To:	Huang Ying <ying.huang@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>,
	Tony Luck <tony.luck@...el.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH] ACPI, APEI, Generic Hardware Error Source POLL/IRQ/NMI
 notification type support

>        if (error_block_length > GHES_ESTATUS_MAX_SIZE) {
>-               pr_warning(FW_WARN GHES_PFX
>-                          "Error status block length is too long: %u for "
>-                          "generic hardware error source: %d.\n",
>+               pr_warning(
>+FW_WARN GHES_PFX "Error status block length is too long: %u for \n"
>+"generic hardware error source: %d.\n",
>                           error_block_length, generic->header.source_id);
>                error_block_length = GHES_ESTATUS_MAX_SIZE;

Hi Ying,

I assume that you are tweaking these pr_warning() lines
to beautify the output, but as far as source
code readability, I liked the previous syntax better.

Although maintainer's opinions vary, I generally do not
strictly enforce the 80 column rule for printk strings.
Ie. I think that code readability with good whitespace
indentation plus printk string grep-ability are more
important than strictly fitting within 80-columns.

thanks,
Len Brown, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/