linux-kernel - RE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A780EBC01B4946F895EA47BE425B56F8@hacdom.okisemi.com>
Date:	Wed, 12 Jan 2011 14:27:12 +0900
From:	"Tomoya MORINAGA" <tomoya-linux@....okisemi.com>
To:	"'Milton Miller'" <miltonm@....com>,
	"'Grant Likely'" <grant.likely@...retlab.ca>
Cc:	"'David Brownell'" <dbrownell@...rs.sourceforge.net>,
	<spi-devel-general@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>, <yong.y.wang@...el.com>,
	<joel.clark@...el.com>, <kok.howg.ewe@...el.com>,
	"'Toshiharu Okada'" <toshiharu-linux@....okisemi.com>,
	"'Wang, Qi'" <qi.wang@...el.com>
Subject: RE: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

On Tuesday, January 11, 2011 6:42 PM, Tomoya MORINAGA wrote:
> However, I couldn't clear my question.

I show the current our coding image.
Is the following agreeable with your saying ?

struct spi_platform_data {
	u16 num_chipselect;
	bool little_endian;
	u8 bits_per_word;
	struct spi_board_info *devices;
	u8 num_devices;
};

static struct resource pch_spi_resources[] = {
	{
		.start 	= 0,
		.end	= 0,
		.flags	= IORESOURCE_MEM,
	},
	{
		.start	= 0,
		.end	= 0,
		.flags	= IORESOURCE_IRQ,
	},
};

static struct spi_platform_data pch_spi_platform_data = {
	.num_chipselect = 2,
	.little_endian = true,
};

static struct pch_spi_cell pch_spi_cfg0 = {
	.name = "pch_spi",
	.num_resources = ARRAY_SIZE(pch_spi_resources),
	.resources = pch_spi_resources,
	.platform_data = &pch_spi_platform_data,
	.data_size = sizeof(pch_spi_platform_data),
};

static int pch_spi_get_resources(struct pch_spi_board_data *board_dat, int num)
{
	int retval;
	int i;

	/* create workqueue */
	board_dat->data[num]->wk = create_singlethread_workqueue(KBUILD_MODNAME);

	pci_request_regions(board_dat->pdev, KBUILD_MODNAME);
}

static int pch_spi_add_device(struct device *parent, int id,
			  struct pch_spi_cell *cell,
			  struct resource *mem_base, int irq_base,
			      struct pch_spi_board_data *board_dat)
{

	platform_device_alloc(cell->name, id + cell->id);

	res = kzalloc(sizeof(*res) * cell->num_resources, GFP_KERNEL);
	if (!res)
		goto fail_device;

	platform_set_drvdata(pdev, cell->driver_data);

	if (cell->data_size) {
		platform_device_add_data(pdev,
					cell->platform_data, cell->data_size);
	}

	for (i = 0; i < cell->num_resources; i++) {
		if ((cell->resources[i].flags & IORESOURCE_MEM) && mem_base) {
			res[i].parent = 
			res[i].start = 
			res[i].end = 
		} else if (cell->resources[i].flags & IORESOURCE_IRQ) {
			res[i].start = 
			res[i].end   = 
		} else {


	}

	ret = platform_device_add_resources(pdev, res, cell->num_resources);
	if (ret)
		goto fail_res;

	ret = platform_device_add(pdev);
	if (ret)
		goto fail_res;

	kfree(res);

	spi_alloc_master( );

	board_dat->data[num] = spi_master_get_devdata( );

	pch_spi_get_resources( );

	/* set master mode */
	pch_spi_set_master_mode( );

	/* Register the controller with the SPI core. */
	spi_register_master( );

	return 0;
}

int pch_spi_add_devices(struct device *parent,
		    struct pch_spi_cell *cells, int n_devs,
		    struct resource *mem_base,
		    struct pch_spi_board_data *board_dat)
{
	pci_iomap()

	for (i < n_devs)
		pch_spi_add_device()

}

static int pch_spi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
{
	board_dat = kzalloc(sizeof(struct pch_spi_board_data), GFP_KERNEL);
	pci_enable_device()
	request_irq()
	pch_spi_add_devices(&pdev->dev, 
			&pch_spi_cfg0,
			2,
			&pdev->resource[0], board_dat);

}

static irqreturn_t pch_spi_handler(int irq, void *dev_id)
{

	for (i = 0; i < board_dat->num; i++) {
		data = board_dat->data[i];
		io_remap_addr = data->io_remap_addr;
		spsr = io_remap_addr + PCH_SPSR;

		reg_spsr_val = ioread32(spsr);

		/* Check if the interrupt is for SPI device */
		if (reg_spsr_val & (SPSR_FI_BIT | SPSR_RFI_BIT)) {
			pch_spi_handler_sub(data, reg_spsr_val, io_remap_addr);
			ret = IRQ_HANDLED;
		}

		dev_dbg(&board_dat->pdev->dev, "%s EXIT return value=%d\n",
			__func__, ret);
	}
	return ret;
}

Thanks,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/