linux-kernel - Re: [PATCH] input: joystick: Adding Austria Microsystem AS5011 joystick driver (fourth version)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Jan 2011 21:50:02 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Fabien Marteau <fabien.marteau@...adeus.com>
Cc:	Scott Moreau <oreaus@...il.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: joystick:   Adding Austria Microsystem AS5011
 joystick driver (fourth version)

On Mon, Jan 10, 2011 at 09:57:59AM +0100, Fabien Marteau wrote:
> Hi Dmitry,
> 
> Thanks for the patch, I tested it on my platform and there is a little bug in irq request for the button :
> 
> +	error = request_threaded_irq(as5011->button_irq,
> +				     NULL, as5011_button_interrupt,
> +				     IRQF_TRIGGER_RISING | IRQF_TRIGGER_RISING,
> +				     "as5011_button", as5011);
> 
> Should be :
> 
> +	error = request_threaded_irq(as5011->button_irq,
> +				     NULL, as5011_button_interrupt,
> +				     IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> +				     "as5011_button", as5011);
> 
> With this modification the patch is ok.
> 

Great, I applied it.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/