| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Jan 2011 22:41:31 -0800 From: Randy Dunlap <rdunlap@...otime.net> To: Maxim Levitsky <maximlevitsky@...il.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org>, Takashi Iwai <tiwai@...e.de>, Alex Dubov <oakad@...oo.com> Subject: Re: [PATCH 1/4] scatterlist: new helper functions On Wed, 12 Jan 2011 04:52:29 +0200 Maxim Levitsky wrote: > > > /** > > > - * sg_compare_to_buffer - compare contents of the data pointeted by sg table > > > + * sg_compare_to_buffer - compare contents of the data covered by an sg table > > > * to a kernel ram buffer > > > - * @sg - the current sg entry > > > - * @buffer - linear buffer to compare with > > > - * @len - lenght of that buffer > > > + * @sg: the current sg entry > > > + * @buffer: linear buffer to compare with > > > + * @len: length of that buffer > > > > Returns what?? > 0 if equal and 1 otherwise. > Was too lazy to implement full strcmp compliance. > Is that needed? Not that I know of, just what the function returns was needed. > All very fair comments. > Will check everything once again. > Thanks for a review! > > Best regards, > Maxim Levitsky > > -- --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists