linux-kernel - Re: [PATCH 05/16] x86: Always use x86_cpu_to_logical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110113105717.GB30719@htj.dyndns.org>
Date:	Thu, 13 Jan 2011 11:57:17 +0100
From:	Tejun Heo <tj@...nel.org>
To:	David Rientjes <rientjes@...gle.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	tglx@...utronix.de, "H. Peter Anvin" <hpa@...or.com>,
	x86@...nel.org, eric.dumazet@...il.com, yinghai@...nel.org,
	brgerst@...il.com, gorcunov@...il.com,
	Pekka Enberg <penberg@...nel.org>, shaohui.zheng@...el.com
Subject: Re: [PATCH 05/16] x86: Always use x86_cpu_to_logical_apicid for
 cpu -> logical apic id

On Wed, Jan 12, 2011 at 06:40:09PM -0800, David Rientjes wrote:
> On Thu, 30 Dec 2010, Tejun Heo wrote:
> 
> > diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> > index ba78b1e..8ad231c 100644
> > --- a/arch/x86/kernel/apic/apic.c
> > +++ b/arch/x86/kernel/apic/apic.c
> > @@ -1252,6 +1252,14 @@ void __cpuinit setup_local_APIC(void)
> >  	 */
> >  	apic->init_apic_ldr();
> >  
> > +#ifdef CONFIG_X86_32
> > +	/*
> > +	 * APIC LDR is initialized.  Fetch and store logical_apic_id.
> > +	 */
> > +	early_per_cpu(x86_cpu_to_logical_apicid, cpu) =
> > +		logical_smp_processor_id();
> > +#endif
> > +
> >  	/*
> >  	 * Set Task Priority to 'accept all'. We never change this
> >  	 * later on.
> 
> You can remove the initialization of x86_cpu_to_logical_apicid in the 
> ->init_apic_ldr() callback in x2apic_cluster.c now too?

Believe it or not, that's a different variable.  And yeah we probably
should clean that up too.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/