linux-kernel - Re: [dm-devel] linux-next - WARNING: at fs/block_dev.c:824 bd_link_disk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110113132637.GH16523@nb.net.home>
Date:	Thu, 13 Jan 2011 14:26:37 +0100
From:	Karel Zak <kzak@...hat.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Milan Broz <mbroz@...hat.com>,
	device-mapper development <dm-devel@...hat.com>,
	"Jun'ichi Nomura" <j-nomura@...jp.nec.com>,
	Valdis.Kletnieks@...edu, linux-kernel@...r.kernel.org,
	linux-raid@...r.kernel.org,
	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org, Kay Sievers <kay.sievers@...y.org>
Subject: Re: [dm-devel] linux-next - WARNING: at fs/block_dev.c:824
	bd_link_disk_holder+0x92/0x1ac()

On Thu, Jan 13, 2011 at 02:12:16PM +0100, Tejun Heo wrote:
> Hello,
> 
> On Thu, Jan 13, 2011 at 01:27:01PM +0100, Karel Zak wrote:
> >  We also use holders/slaves links in libblkid to evaluate dependencies
> >  between devices (since 2008).
> > 
> > > Whatever changes are needed, please keep this functionality, it
> > > can be useful.
> > 
> >  Definitely.
> 
> Yeah, sure, it's not like I can afford to avoid fixing it at this
> point anyway, but I still want to point out it's at the wrong layer
> and shouldn't have been added like this, really.  If you want blkid to
> identify it, the proper thing to do would be querying blk device for
> the claimer and then use claimer-specific method to query them.  It's

 It seems that dependencies (holders/slaves) between devices is pretty
 generic thing. Why do you think that we need claimer-specific method?
 The /sys filesystem is better that ictls in many ways.

> not like the current method would make sense for btrfs or whatnot.

 Could you be more verbose, please?

    Karel

-- 
 Karel Zak  <kzak@...hat.com>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/