linux-kernel - Re: ecryptfs build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110113220554.GA8313@boyd.l.tihix.com>
Date:	Thu, 13 Jan 2011 16:05:55 -0600
From:	Tyler Hicks <tyhicks@...ux.vnet.ibm.com>
To:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:	Dustin Kirkland <kirkland@...onical.com>,
	ecryptfs-devel@...ts.launchpad.net, linux-kernel@...r.kernel.org
Subject: Re: ecryptfs build failure

On Thu Jan 13, 2011 at 11:15:35PM +0200, Sergey Senozhatsky <sergey.senozhatsky@...il.com> wrote:
> Hello,
> 
> Recent kernel failed to build due to ecryptfs/main.
> 2 of 3 errors could be fixed with the following patch. The third is:
> we make an assignment `lower_inode = lower_dentry->d_inode;' in
> ecryptfs_get_inode, yet ecryptfs_get_inode knows nothing about lower_dentry.

Thanks - This was mentioned just a little bit ago on LKML by Eric
Dumazet ([BUG] ECRYPT_FS) and Christoph responded with a patch. FWIW,
it doesn't look like the patch below addresses the lower_dentry issue in
ecryptfs_get_inode().

Tyler

> 
> ---
> 
>  fs/ecryptfs/main.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
> index 9ed4769..5694d65 100644
> --- a/fs/ecryptfs/main.c
> +++ b/fs/ecryptfs/main.c
> @@ -141,7 +141,7 @@ int ecryptfs_init_persistent_file(struct dentry *ecryptfs_dentry)
>  	return rc;
>  }
> 
> -static inode *ecryptfs_get_inode(struct inode *lower_inode,
> +static struct inode *ecryptfs_get_inode(struct inode *lower_inode,
>  		       struct super_block *sb)
>  {
>  	struct inode *inode;
> @@ -202,7 +202,7 @@ int ecryptfs_interpose(struct dentry *lower_dentry, struct dentry *dentry,
>  {
>  	struct inode *lower_inode = lower_dentry->d_inode;
>  	struct inode *inode = ecryptfs_get_inode(lower_inode, sb);
> -	if (IS_ERR(inode)
> +	if (IS_ERR(inode))
>  		return PTR_ERR(inode);
>  	if (flags & ECRYPTFS_INTERPOSE_FLAG_D_ADD)
>  		d_add(dentry, inode);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/