linux-kernel - Bad array index in arch/x86/mm/numa_64.c::debug_cpumask_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1101132318010.11347@swampdragon.chaosbits.net>
Date:	Thu, 13 Jan 2011 23:26:09 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	linux-kernel@...r.kernel.org
cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Yinghai Lu <yinghai@...nel.org>,
	David Rientjes <rientjes@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Bad array index in arch/x86/mm/numa_64.c::debug_cpumask_set_cpu()

Hi,

In arch/x86/mm/numa_64.c::debug_cpumask_set_cpu() we call 
early_cpu_to_node() which may return NUMA_NO_NODE (which has the value 
-1). This value is subsequently used as an index into 
the 'node_to_cpumask_map' array and '-1' is not going to fly too wel as an 
array index here.

This code comes from commit d906f0eb2f0e6d1a24c479f69a9c39e7e45c5ae8
"x86, numa: Fix CONFIG_DEBUG_PER_CPU_MAPS without NUMA emulation".

I must admit I have no idea what the best way to deal with this is, so 
I'll just report it.

Happy bug fixing.

-- 
Jesper Juhl <jj@...osbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/