linux-kernel - Re: [PATCH] tty/tty_io.c: fix compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D301239.5030303@gmail.com>
Date:	Fri, 14 Jan 2011 10:07:05 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Viresh Kumar <viresh.kumar@...com>
CC:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	Kay Sievers <kay.sievers@...e.de>
Subject: Re: [PATCH] tty/tty_io.c: fix compilation warning

On 01/14/2011 08:18 AM, Viresh Kumar wrote:
> This patch fixes following compilation warning:
> tty/tty_io.c:3309: warning: ignoring return value of 'device_create_file',
> declared with attribute warn_unused_result
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...com>
> ---
>  drivers/tty/tty_io.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
> index 464d09d..b558f03 100644
> --- a/drivers/tty/tty_io.c
> +++ b/drivers/tty/tty_io.c
> @@ -3291,6 +3291,8 @@ void console_sysfs_notify(void)
>   */
>  int __init tty_init(void)
>  {
> +	int ret = 0;
> +
>  	cdev_init(&tty_cdev, &tty_fops);
>  	if (cdev_add(&tty_cdev, MKDEV(TTYAUX_MAJOR, 0), 1) ||
>  	    register_chrdev_region(MKDEV(TTYAUX_MAJOR, 0), 1, "/dev/tty") < 0)
> @@ -3306,11 +3308,11 @@ int __init tty_init(void)
>  	if (IS_ERR(consdev))
>  		consdev = NULL;
>  	else
> -		device_create_file(consdev, &dev_attr_active);
> +		ret = device_create_file(consdev, &dev_attr_active);
>  
>  #ifdef CONFIG_VT
>  	vty_init(&console_fops);
>  #endif
> -	return 0;
> +	return ret;

NACK

There is no failpath handling. And I think Kay has a patch for that
already where he ignores the retval.

regards,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/