linux-kernel - Re: [PATCH resend] kernel/async.c: fixing compilation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D304BE6.9070200@fastmail.fm>
Date:	Fri, 14 Jan 2011 13:13:10 +0000
From:	Jack Stone <jwjstone@...tmail.fm>
To:	Viresh Kumar <viresh.kumar@...com>
CC:	linux-kernel@...r.kernel.org, arjan@...ux.intel.com
Subject: Re: [PATCH resend] kernel/async.c: fixing compilation warnings

[cc Arjan van de Ven]
On 14/01/2011 11:53, Viresh Kumar wrote:
> This patch fixes following compilation warnings:
> 270:10: warning: ‘starttime.tv64’ may be used uninitialized in this function
> 122:10: warning: ‘calltime.tv64’ may be used uninitialized in this function
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...com>

Looks good to me

Reviewed-by: Jack Stone <jwjstone@...tmail.fm>
> ---
>  kernel/async.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/async.c b/kernel/async.c
> index cd9dbb9..3ff777b 100644
> --- a/kernel/async.c
> +++ b/kernel/async.c
> @@ -119,7 +119,7 @@ static void async_run_entry_fn(struct work_struct *work)
>  	struct async_entry *entry =
>  		container_of(work, struct async_entry, work);
>  	unsigned long flags;
> -	ktime_t calltime, delta, rettime;
> +	ktime_t uninitialized_var(calltime), delta, rettime;
>  
>  	/* 1) move self to the running queue */
>  	spin_lock_irqsave(&async_lock, flags);
> @@ -267,7 +267,7 @@ EXPORT_SYMBOL_GPL(async_synchronize_full_domain);
>  void async_synchronize_cookie_domain(async_cookie_t cookie,
>  				     struct list_head *running)
>  {
> -	ktime_t starttime, delta, endtime;
> +	ktime_t uninitialized_var(starttime), delta, endtime;
>  
>  	if (initcall_debug && system_state == SYSTEM_BOOTING) {
>  		printk("async_waiting @ %i\n", task_pid_nr(current));

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/