linux-kernel - Re: [PATCH] Trusted and Encrypted Keys: fix up TSS_rawhmac() so wealways kfree() and remember to call va

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201101142245.GGI86457.OQFFFMOtVOHJLS@I-love.SAKURA.ne.jp>
Date:	Fri, 14 Jan 2011 22:45:12 +0900
From:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To:	safford@...son.ibm.com
Cc:	dhowells@...hat.com, safford@...ibm.com, jmorris@...ei.org,
	keyrings@...ux-nfs.org, linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Trusted and Encrypted Keys: fix up TSS_rawhmac() so wealways kfree() and remember to call va_end()

David Safford wrote:
> On Thu, 2011-01-13 at 21:07 +0100, Jesper Juhl wrote:
> > In security/keys/trusted_defined.c::TSS_rawhmac() we may leak the storage 
> > allocated to 'sdesc' if
> >   data = va_arg(argp, unsigned char *);
> > results in a NULL 'data' and we then leave the function by returning 
> > -EINVAL. We also neglect calling va_end(argp) in that case and furthermore 
> > we neglect va_end(argp) if
> >   ret = crypto_shash_update(&sdesc->shash, data, dlen);
> > results in ret being negative and we then jump to the 'out' label.
> > 
> > I believe this patch takes care of these issues. Please review and 
> > consider for inclusion.
> > 
> > Signed-off-by: Jesper Juhl <jj@...osbits.net>
> 
> thanks for catching this.
> 
> Acked-by: David Safford <safford@...son.ibm.com>

Please wait. That patch is incorrect. I'm making patch now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/