linux-kernel - [PATCH resend] Bluetooth: l2cap: fix misuse of logical operation in place of bitop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1295013584-15592-1-git-send-email-dsterba@suse.cz>
Date:	Fri, 14 Jan 2011 14:59:44 +0100
From:	David Sterba <dsterba@...e.cz>
To:	akpm@...ux-foundation.org
Cc:	marcel@...tmann.org, linux-bluetooth@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	David Sterba <dsterba@...e.cz>,
	"Gustavo F. Padovan" <padovan@...fusion.mobi>,
	João Paulo Rechi Vita 
	<jprvita@...fusion.mobi>
Subject: [PATCH resend] Bluetooth: l2cap: fix misuse of logical operation in place of bitop

CC: Marcel Holtmann <marcel@...tmann.org>
CC: "Gustavo F. Padovan" <padovan@...fusion.mobi>
CC: João Paulo Rechi Vita <jprvita@...fusion.mobi>
Signed-off-by: David Sterba <dsterba@...e.cz>
---

Andrew, this has not been picked up by maintainers since 27.12., please consider it for -mm.

 net/bluetooth/l2cap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
index cd8f6ea..bdfdfdc 100644
--- a/net/bluetooth/l2cap.c
+++ b/net/bluetooth/l2cap.c
@@ -1893,8 +1893,8 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, struct ms
 		if (pi->mode == L2CAP_MODE_STREAMING) {
 			l2cap_streaming_send(sk);
 		} else {
-			if (pi->conn_state & L2CAP_CONN_REMOTE_BUSY &&
-					pi->conn_state && L2CAP_CONN_WAIT_F) {
+			if ((pi->conn_state & L2CAP_CONN_REMOTE_BUSY) &&
+					(pi->conn_state & L2CAP_CONN_WAIT_F)) {
 				err = len;
 				break;
 			}
-- 
1.7.3.4.626.g73e7b

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/