linux-kernel - RE: [PATCH] Fix build failure when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E31FB011129F30488D5861F3839049151D10FD013E@BLRX7MCDC201.AMER.DELL.COM>
Date:	Fri, 14 Jan 2011 21:36:06 +0530
From:	<Narendra_K@...l.com>
To:	<sedat.dilek@...il.com>
CC:	<jbarnes@...tuousgeek.org>, <lenb@...nel.org>,
	<linux-kernel@...r.kernel.org>, <linux-next@...r.kernel.org>,
	<sfr@...b.auug.org.au>, <Matt_Domsch@...l.com>,
	<Charles_Rose@...l.com>, <Surya_Prabhakar@...l.com>
Subject: RE: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by
 allmodconfig

> Subject: Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by
> allmodconfig
> 
> On Fri, Jan 14, 2011 at 4:22 PM,  <Narendra_K@...l.com> wrote:
> > On Thu, Jan 13, 2011 at 09:33:56PM +0530, K, Narendra wrote:
> >> On Thu, Jan 13, 2011 at 09:25:56PM +0530, Jesse Barnes wrote:
> >> > On Wed, 12 Jan 2011 22:23:55 -0500 (EST)
> >> > Len Brown <lenb@...nel.org> wrote:
> >> > > > So there's no other ACPI code that depends on this function?
>  I'd hate
> >> > > > to make PCI depend on NLS, so assuming ACPI doesn't need it
> (in which
> >> > > > case the select or depend should be there), I guess it should
> be pulled
> >> > > > into a common file that will always be included.
> >> > >
> >> > > No, nothing in the ACPI code uses utf16s_to_utf8s.
> >> > >
> >> > > I don't know anything about NLS, but it appears to be
> >> > > something that file systems (befs, cifs, fat, hfs, isofs, jfs,
> etc)
> >> > > use to to support native languages.
> >> > >
> >> > > BTW. I don't understand why pci-label.o appears twice above.
> >> > > It used to be just the 2nd one, that depends on CONFIG_DMI.
> >> >
> >> > Ok, I'll drop this patch for now then since I haven't seen a fix
> yet
> >> > and need to get Linus the rest of the changes.
> >>
> >> Jesse,
> >>
> >> I just compile tested a fix on the following lines without any
> failure.
> >> If it is acceptable, i will send a patch in half an hour. It builds
> >>
> >
> > Hello,
> >
> > This patch addresses the build failure described in this thread by
> > compiling fs/nls/nls_base.c always into vmlinux, thus making the base
> > nls functions available always.
> >
> > Please consider this patch for inclusion if there are no concerns
> with
> > this approach.
> >
> 
> So NLS is built always?
> You thought of embedded devices like router platforms which want to
> reduce their kernel (size) by not building NLS?

Only nls_base.c is built always and not the other files under fs/nls/ dir. I considered moving 'utf16s_to_utf8s' to a new file nls_common.c, but 'utf16s_to_utf8s' requires 'utf32_to_utf8' also. I suppose nls_base.c has only the minimum required functions and moving out two functions out of it might not be the right approach. Sorry if I am missing something here.

Please let me know if this can be addressed in an alternative way.

With regards,
Narendra K