linux-kernel - Re: [PATCH] Fix build failure when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110115080949.62176a3c.sfr@canb.auug.org.au>
Date:	Sat, 15 Jan 2011 08:09:49 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	<Narendra_K@...l.com>
Cc:	<jbarnes@...tuousgeek.org>, <lenb@...nel.org>,
	<linux-kernel@...r.kernel.org>, <linux-next@...r.kernel.org>,
	<Matt_Domsch@...l.com>, <Charles_Rose@...l.com>,
	<Surya_Prabhakar@...l.com>
Subject: Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by
 allmodconfig

Hi Narendra,

On Fri, 14 Jan 2011 20:52:42 +0530 <Narendra_K@...l.com> wrote:
>
> This patch addresses the build failure described in this thread by
> compiling fs/nls/nls_base.c always into vmlinux, thus making the base
> nls functions available always.

Even on platforms that don't support ACPI or DMI ...

> From: Narendra K <narendra_k@...l.com>
> Subject: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig
> 
> This patch fixes the following build breakage introduced by the patch
> PCI:export ACPI _DSM provided firmware instance number and string to sysfs.
> (previously commit a6247cd4be20cb5439db5cb7b0b6cc67fdc8e2a2).
> 
> http://marc.info/?l=linux-pci&m=129313294112736&w=1
> 
> drivers/built-in.o: In function `T.647':
> pci-label.c:(.text+0x28514): undefined reference to `utf16s_to_utf8s'
> 
> This happens because 'make allmodconfig' sets CONFIG_NLS=m and makes
> 'utf16s_to_utf8s` unavailable to drivers/pci/pci-label.o which is built
> into vmlinux.
> 
> This is fixed by making fs/nls/nls_base.c always compile as part of
> vmlinux thus making the base nls functions available always.
> +++ b/fs/nls/Makefile
> @@ -2,7 +2,7 @@
>  # Makefile for native language support
>  #
>  
> -obj-$(CONFIG_NLS)		+= nls_base.o
> +obj-y				+= nls_base.o

You should really restrict this to CONFIG_ACPI || CONFIG_DMI ||
CONFIG_NLS ... maybe create a CONFIG_NLS_BASE that is selected by ACPI,
DMI and NLS?

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped