linux-kernel - Re: [PATCH] mtd: sst25l: fix reads with broken spi-masters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 14 Jan 2011 14:34:33 -0800 (PST)
From:	David Brownell <david-b@...bell.net>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>,
	Grant Likely <grant.likely@...retlab.ca>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"spi-devel-general@...ts.sourceforge.net" 
	<spi-devel-general@...ts.sourceforge.net>,
	David Woodhouse <dwmw2@...radead.org>,
	"Artem.Bityutskiy@...ia.com" <Artem.Bityutskiy@...ia.com>
Subject: Re: [PATCH] mtd: sst25l: fix reads with broken spi-masters



--- On Fri, 1/14/11, Grant Likely <grant.likely@...retlab.ca> wrote:

> > The bug _is_ in the spi peripheral on the ep93xx.
> > 

> 
> No, David is correct.  The fault is in the master
> driver.  It is perfectly valid (and common) for spi
> peripherals to required the SS line to remain asserted over
> the entire transfer. 

And that's what the Linux SPI stack requires,
so any master driver that doesn't keep the
slave selected during the entiretransfer is buggy.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/