linux-kernel - Re: NFS OOps - kernel BUG at fs/nfs/nfs3xdr.c:1338

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1295048791.20016.15.camel@heimdal.trondhjem.org>
Date:	Fri, 14 Jan 2011 18:46:31 -0500
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	Milan Broz <mbroz@...hat.com>,
	"Mr. Charles Edward Lever" <Chuck.Lever@...cle.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-nfs@...r.kernel.org
Subject: Re: NFS OOps  - kernel BUG at fs/nfs/nfs3xdr.c:1338

On Sat, 2011-01-15 at 00:18 +0100, Milan Broz wrote: 
> Hi,
> 
> on today Linus' tree I get OOps if using nfs.
> 
> server (2.6.36) exports dir:
> /dir   172.16.1.0/24(rw,async,all_squash,no_subtree_check,anonuid=500,anongid=500)
> 
> on client it is mounted  in fstab
> server:/dir  /mnt/tst  nfs  rw,soft 0 0
> 
> and these commands OOpses it (simplified from a configure script):
> 
> cd /dir
> touch x
> install x y
> 
> [  105.327701] ------------[ cut here ]------------
> [  105.327979] kernel BUG at fs/nfs/nfs3xdr.c:1338!

Chuck, why did you add those BUG_ON()s there? I know that
nfsacl_encode() is for some unfathomable reason declared as returning an
unsigned integer, but if you look at the actual code, you will see that
it returns a number of negative signed error values depending on whether
or not allocations succeeded, number of entries is valid, etc...

IOW: negative values are perfectly allowable here, and should simply
cause the rpc call to be aborted, not an Oops.

Trond
-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/